SourceControl: rename useBuiltinFSMonitor to fsmonitor
#6549
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git 2.36.0 renamed `useBuiltinFSMonitor` to `fsmonitor`. This configuration setting results in a warning. Given that Git 2.36.0 is now over a year old, rename the option we use to silence the warning. In the case of an installation of git predating the configuration renaming, we could run into issues with git opening the files preventing subsequent git operations, but in the general case, this should be equivalent.
compnerd
requested review from
abertelrud,
neonichu,
tomerd and
MaxDesiatov
as code owners
|
@swift-ci please test |
neonichu
approved these changes
May 12, 2023
|
@swift-ci smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Git 2.36.0 renamed
useBuiltinFSMonitortofsmonitor. This configuration setting results in a warning. Given that Git 2.36.0 is now over a year old, rename the option we use to silence the warning. In the case of an installation of git predating the configuration renaming, we could run into issues with git opening the files preventing subsequent git operations, but in the general case, this should be equivalent.