Delete macOS triple hardcode #6569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleksproger
requested review from
abertelrud,
neonichu,
tomerd and
MaxDesiatov
as code owners
neonichu
approved these changes
May 17, 2023
MaxDesiatov
approved these changes
May 17, 2023
|
@swift-ci smoke test |
added 2 commits
May 19, 2023 10:59
On macOS hostTriple hardcoded as `x86_64-apple-macosx` which may not reflect the real host triple. As far as I understand the latest Xcode version are shipped with `-print-target-info` compatible compiler which allows to get rid of this `FIXME` `New behaviour` Host triple received from compiler even on macOS `Motivation` Cleanup of small FIXME `Result` Host triple for macOS no more a hardcoded value
aleksproger
force-pushed
the
sapitskiy/fix-hardcoded-macos-triple
branch
from
4368b68 to
ccc3c10
Compare
|
@swift-ci smoke test |
|
@swift-ci test windows |
|
@MaxDesiatov seems like you may merge it now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On macOS hostTriple hardcoded as
x86_64-apple-macosxwhich may not reflect the real host triple. As far as I understand the latest Xcode version are shipped with-print-target-infocompatible compiler which allows to get rid of thisFIXMEMotivation:
Xcode ships with necessary
-print-target-infooptionCleanup of small FIXME and misleading hardcoded value
Modifications:
Make a call to swift compiler on macOS to retrieve the triple information
Result:
macOS triple now reflects real value received from swift compiler