Tests: adjust PackageModelTests for Windows

[compnerd]

Adjust the path spelling for the native path arc separator and escaping
for the encoding in the JSON. Windows uses \ as the path arc
separator which needs to be escaped for ensuring that the JSON is valid.

[compnerd]

@swift-ci please smoke test

[compnerd]

@swift-ci please smoke test

[compnerd]

@swift-ci please test Windows platform

[compnerd]

@swift-ci please smoke test

[tomerd]

all these use of _nativePathString(escaped: true) makes me feel bit uncomfortable and maybe pointing to something more broadly missing

[compnerd]

all these use of _nativePathString(escaped: true) makes me feel bit uncomfortable and maybe pointing to something more broadly missing

I don't feel that is the case. We need to ensure that the JSON that we are hardcoding here is valid - the paths have \ as the arc separator, we need to escape them.

[compnerd]

@swift-ci please test Windows platform

[tomerd]

all these use of _nativePathString(escaped: true) makes me feel bit uncomfortable and maybe pointing to something more broadly missing

I don't feel that is the case. We need to ensure that the JSON that we are hardcoding here is valid - the paths have \ as the arc separator, we need to escape them.

right, I understand why it was done. the point is that if need to litter too many of our tests with _nativePathString(escaped: true) it points to needing a different approach potentially

[compnerd]

all these use of _nativePathString(escaped: true) makes me feel bit uncomfortable and maybe pointing to something more broadly missing

I don't feel that is the case. We need to ensure that the JSON that we are hardcoding here is valid - the paths have \ as the arc separator, we need to escape them.

right, I understand why it was done. the point is that if need to litter too many of our tests with _nativePathString(escaped: true) it points to needing a different approach potentially

The only alternative that comes to mind is to encode the structure and rely on Codable to serialise to a JSON string.

[compnerd]

@swift-ci please smoke test

[MaxDesiatov]

Nice, thank you!