Remove emitSwiftModuleSeparately option
#6779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This option has always been off by default and there are no particular tests for it, so I think we should just remove it since it makes maintaining `SwiftTargetBuildDescription` unnecessarily difficult. From what I can gather, this was supposed to be an optimization for build times that maybe was supposed to be tested, but it ended up never being enabled.
|
@swift-ci please smoke test |
|
I'm also pretty sure this option hasn't fully worked in a while, there are all these odds differences between this mode and the "regular" one when looking at |
|
seems reasonable. can git history tell us when/who added it originally? maybe worth checking in and confirming the assumptions |
Yes, it was added in #2391 |
MaxDesiatov
approved these changes
Aug 4, 2023
tomerd
approved these changes
Aug 5, 2023
|
For reference, I spoke to Doug and the conclusion was that not only this but also the current default mode should eventually go away and we should use the integrated driver. The refactoring that this is a part of should help us to eventually get there. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This option has always been off by default and there are no particular tests for it, so I think we should just remove it since it makes maintaining
SwiftTargetBuildDescriptionunnecessarily difficult. From what I can gather, this was supposed to be an optimization for build times that maybe was supposed to be tested, but it ended up never being enabled.