Update CHANGELOG.md to reflect 5.9 scope #6839
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
requested review from
abertelrud,
neonichu and
MaxDesiatov
as code owners
tomerd
commented
Aug 22, 2023
|
Should we add something for https://developer.apple.com/documentation/packagedescription/swiftsetting/interoperabilitymode(_:_:)/? |
yim-lee
reviewed
Aug 23, 2023
MaxDesiatov
reviewed
Aug 23, 2023
MaxDesiatov
reviewed
Aug 23, 2023
MaxDesiatov
reviewed
Aug 23, 2023
Co-authored-by: Max Desiatov <m_desiatov@apple.com>
Co-authored-by: Max Desiatov <m_desiatov@apple.com>
Co-authored-by: Yim Lee <yim_lee@apple.com>
Co-authored-by: Max Desiatov <m_desiatov@apple.com>
MaxDesiatov
reviewed
Aug 23, 2023
|
@swift-ci smoke test |
|
@swift-ci test windows |
MaxDesiatov
reviewed
Aug 23, 2023
Co-authored-by: Max Desiatov <m_desiatov@apple.com>
|
@swift-ci smoke test |
|
@swift-ci smoke test windows |
|
@swift-ci smoke test linux |
|
@swift-ci smoke test lnux |
|
@swift-ci smoke test linux |
|
@hyp ptal at the description for interoperablotyMode and suggest any changes |
neonichu
reviewed
Aug 25, 2023
| * [#6067] | ||
|
|
||
| Basic support for a new `.embedInCode` resource rule which allows embedding the contents of the resource into the executable code by generating a byte array, e.g. | ||
|
|
||
| ``` | ||
| struct PackageResources { | ||
| static let best_txt: [UInt8] = [104,101,108,108,111,32,119,111,114,108,100,10] | ||
| static let best_txt: [UInt8] = [104,101,108,108,111,32,119,111,114,108,100,10] |
There was a problem hiding this comment.
Hm, why is a space here? It definitely won't be there in the generated code :)
There was a problem hiding this comment.
just to improve formatting?
neonichu
approved these changes
Aug 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: improve CHANGELOG.md
changes: