Compute path to swift-plugin-server on demand
#6899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This takes a significant amount of time when the selected Xcode doesn't have a `swift-plugin-server` executable: ``` /tmp/exec ❯ time /usr/bin/xcrun --find swift-plugin-server xcrun: error: sh -c '/Users/neonacho/Downloads/Xcode.app/Contents/Developer/usr/bin/xcodebuild -sdk /Users/neonacho/Downloads/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk -find swift-plugin-server 2> /dev/null' failed with exit code 17664: (null) (errno=No such file or directory) xcrun: error: unable to find utility "swift-plugin-server", not a developer tool or in PATH /usr/bin/xcrun --find swift-plugin-server 0.34s user 0.17s system 32% cpu 1.579 total ``` Doing this on demand is at least gated on `self.buildParameters.toolchain.isSwiftDevelopmentToolchain` so it shouldn't happen for the primary usage scenario on macOS.
|
@swift-ci please test |
tomerd
approved these changes
Sep 14, 2023
|
should we cherry pick this to 5.9 as well? |
MaxDesiatov
pushed a commit
that referenced
this pull request
Sep 28, 2023
This takes a significant amount of time when the selected Xcode doesn't have a `swift-plugin-server` executable: ``` /tmp/exec ❯ time /usr/bin/xcrun --find swift-plugin-server xcrun: error: sh -c '/Users/neonacho/Downloads/Xcode.app/Contents/Developer/usr/bin/xcodebuild -sdk /Users/neonacho/Downloads/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk -find swift-plugin-server 2> /dev/null' failed with exit code 17664: (null) (errno=No such file or directory) xcrun: error: unable to find utility "swift-plugin-server", not a developer tool or in PATH /usr/bin/xcrun --find swift-plugin-server 0.34s user 0.17s system 32% cpu 1.579 total ``` Doing this on demand is at least gated on `self.buildParameters.toolchain.isSwiftDevelopmentToolchain` so it shouldn't happen for the primary usage scenario on macOS.
MaxDesiatov
pushed a commit
that referenced
this pull request
Sep 28, 2023
This takes a significant amount of time when the selected Xcode doesn't have a `swift-plugin-server` executable: ``` /tmp/exec ❯ time /usr/bin/xcrun --find swift-plugin-server xcrun: error: sh -c '/Users/neonacho/Downloads/Xcode.app/Contents/Developer/usr/bin/xcodebuild -sdk /Users/neonacho/Downloads/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX13.3.sdk -find swift-plugin-server 2> /dev/null' failed with exit code 17664: (null) (errno=No such file or directory) xcrun: error: unable to find utility "swift-plugin-server", not a developer tool or in PATH /usr/bin/xcrun --find swift-plugin-server 0.34s user 0.17s system 32% cpu 1.579 total ``` Doing this on demand is at least gated on `self.buildParameters.toolchain.isSwiftDevelopmentToolchain` so it shouldn't happen for the primary usage scenario on macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This takes a significant amount of time when the selected Xcode doesn't have a
swift-plugin-serverexecutable:Doing this on demand is at least gated on
self.buildParameters.toolchain.isSwiftDevelopmentToolchainso it shouldn't happen for the primary usage scenario on macOS.