[NFC] SPMBuildCore: make BuildSystemProvider.Provider a protocol
#6984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Motivation: When expressed as a closure, it confuses the type checker when working on any related code. Multi-line closure type inference has been known to be suboptimal in Swift, and converting it to a protocol localizes "Type of expression is ambiguous without a type annotation" to a specific line that causes the error instead of attaching it to the whole closure. ### Modifications: Created a new `protocol BuildSystemFactory` with a `makeBuildSystem` method that replaces the previous `BuildSystemProvider.Provider` closure typealias. Added new `private struct NativeBuildSystemFactory` and `private struct XcodeBuildSystemFactory` in `BuildSystemSupport.swift`, which conform to the new protocol and are used in the implementation of `defaultBuildSystemProvider` computed property. ### Result: It's much easier to work with `BuildSystemFactory` protocol: it no longer confuses the type checker when changes to the closure body are made or need to be made. Additionally, the new protocol method can use named function arguments instead of unnamed ones, since closures don't support the former. (cherry picked from commit 7f81baf)
MaxDesiatov
added
build system
|
@swift-ci test |
|
@swift-ci test windows |
neonichu
approved these changes
Oct 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
When requirements are expressed as a closure type (
BuildSystemProvider.Providerin this case), it confuses the type checker when working on any related code. Multi-line closure type inference has been known to be suboptimal in Swift, and converting it to a protocol localizes "Type of expression is ambiguous without a type annotation" to a specific line that causes the error instead of attaching it to the whole closure.Modifications:
Created a new
protocol BuildSystemFactorywith amakeBuildSystemmethod that replaces the previousBuildSystemProvider.Providerclosure typealias. Added newprivate struct NativeBuildSystemFactoryandprivate struct XcodeBuildSystemFactoryinBuildSystemSupport.swift, which conform to the new protocol and are used in the implementation ofdefaultBuildSystemProvidercomputed property.Result:
It's much easier to work with
BuildSystemFactoryprotocol: it no longer confuses the type checker when changes to the closure body are made or need to be made. Additionally, the new protocol method can use named function arguments instead of unnamed ones, since closures don't support the former.