refine location comparison when pre-loading package state from local state #7002
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomerd
changed the title
tomerd
force-pushed
the
radar/105732543
branch
from
35517d0 to
73f5e42
Compare
|
@swift-ci test |
|
@swift-ci test macOS |
1 similar comment
|
@swift-ci test macOS |
MaxDesiatov
reviewed
Oct 14, 2023
| @@ -125,3 +125,12 @@ final class ContainerProvider { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| extension ThreadSafeKeyValueStore where Key == PackageReference, Value == PubGrubPackageContainer { | |||
| subscript(comparingLocation package: PackageReference) -> PubGrubPackageContainer? { | |||
There was a problem hiding this comment.
nit: missing doc comment
…state motivation: when changing between canonical dependency URLs SwiftPM over-caches and ignores changes in manifest until local cache is deleted. this can lead to auth issues when switching between https and ssh for example changes: * take into account URL scheme when comparing dependency locations * always prefer root dependencies when computing preferred URLs * clean up call sites that compare dependecy location * add and expand tests rdar://105732543
tomerd
force-pushed
the
radar/105732543
branch
from
73f5e42 to
4cd8482
Compare
tomerd
force-pushed
the
radar/105732543
branch
from
4cd8482 to
60454ae
Compare
|
@swift-ci test |
neonichu
approved these changes
Oct 17, 2023
|
@swift-ci test windows |
tomerd
added a commit
that referenced
this pull request
Oct 25, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: when changing between canonical dependency URLs SwiftPM over-caches and ignores changes in manifest until local cache is deleted. this can lead to auth issues when switching between https and ssh for example
changes:
rdar://105732543