Skip to content

Do not validate unused SCM dependencies #7036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

neonichu
Copy link
Contributor

Currently, we are doing unconditional validation of any SCM dependencies which can lead to unexpected and confusing results, e.g. the branch of a SCM dependency that is overidden by a root failing validation and breaking builds. We should only validate what we actually use.

rdar://117442643

Currently, we are doing unconditional validation of any SCM dependencies which can lead to unexpected and confusing results, e.g. the branch of a SCM dependency that is overidden by a root failing validation and breaking builds. We should only validate what we actually use.

rdar://117442643
@neonichu
Copy link
Contributor Author

I'm not sure how most of the loadRoot* APIs in workspace are supposed to be used and are supposed to work.

It seems like many of them are used interchangeably even though they seem mutually exclusive e.g. loadRootManifests() vs. loadRootPackage(). Because of this I opted for the client always providing the list of root package identities since that is the only one who can know them based on the current API surface. That said, the client mostly also doesn't have this information, so we can just pass in what we know about at the time...

@neonichu neonichu self-assigned this Oct 25, 2023
Copy link
Contributor

@tomerd tomerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let see if there are alternative approaches

@neonichu
Copy link
Contributor Author

let see if there are alternative approaches

I think we were saying we would consider dropping the SCM validation at this stage.

Separately, we also need to change when these validations happen since currently they're performed multiple times in a single SwiftPM invocation, leading to duplicated diagnostics.

@neonichu
Copy link
Contributor Author

neonichu commented Nov 1, 2023

Closing in favor of #7048

@neonichu neonichu closed this Nov 1, 2023
@neonichu neonichu deleted the dont-validate-unused-scm-deps branch November 1, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants