Disable branch name validation #7037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This validation happens unconditionally after parsing a manifest, so even if a dependency may be unused or overidden which is undesirable and unexpected. We need to either provide context or move the validation, but this currently breaks builds in environments where the validation doesn't succeed, so to unblock, we can disable it. rdar://117330410
|
@swift-ci please test |
MaxDesiatov
approved these changes
Oct 25, 2023
neonichu
added a commit
that referenced
this pull request
Nov 1, 2023
As a follow-up to #7037, we decided to disable this bogus validation entirely since it doesn't add value compared to git's own output (it actually decreases the value since e.g. it omits the repository in question), it was emitted multiple times (probably still a bug for other validations that needs to be fixed) and it was unconditional, so e.g. it could cause SwiftPM to fail in cases where the branch/revision wouldn't be used anyway. I also opted to remove the existing test here since it doesn't seem to be very useful for us to test git itself. We will now always just use git and the user will get the same behavior as when they're using an invalid branch with git itself. rdar://117442643
neonichu
added a commit
that referenced
this pull request
Nov 1, 2023
As a follow-up to #7037, we decided to disable this bogus validation entirely since it doesn't add value compared to git's own output (it actually decreases the value since e.g. it omits the repository in question), it was emitted multiple times (probably still a bug for other validations that needs to be fixed) and it was unconditional, so e.g. it could cause SwiftPM to fail in cases where the branch/revision wouldn't be used anyway. I also opted to remove the existing test here since it doesn't seem to be very useful for us to test git itself. We will now always just use git and the user will get the same behavior as when they're using an invalid branch with git itself. rdar://117442643
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This validation happens unconditionally after parsing a manifest, so even if a dependency may be unused or overidden which is undesirable and unexpected. We need to either provide context or move the validation, but this currently breaks builds in environments where the validation doesn't succeed, so to unblock, we can disable it.
rdar://117330410