[NFC] Remove unused fileSystem from GraphLoadingNode
#7154
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`GraphLoadingNode` in the same graph always use same file system instance, there's no need to store references to it in each node. We should remove this property, as it also simplifies `Equatable` and `Hashable` implementations on this type.
MaxDesiatov
added
the
no functional change
|
@swift-ci test |
tomerd
approved these changes
Dec 1, 2023
MaxDesiatov
added a commit
that referenced
this pull request
Dec 2, 2023
### Motivation: `GraphLoadingNode`s in the same graph always use same file system instance, there's no need to store references to it in each node. ### Modifications: Removed `fileSystem` property on `GraphLoadingNode`, as it also simplifies `Equatable` and `Hashable` implementations on this type. ### Result: `GraphLoadingNode` is now a true value type, with no need to define `Equatable` and `Hashable` manually on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
GraphLoadingNodes in the same graph always use same file system instance, there's no need to store references to it in each node.Modifications:
Removed
fileSystemproperty onGraphLoadingNode, as it also simplifiesEquatableandHashableimplementations on this type.Result:
GraphLoadingNodeis now a true value type, with no need to defineEquatableandHashablemanually on it.