Skip to content

[PubGrub] Avoid resolving package versions twice in presence of prebuilt libraries #7436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 4, 2024

Conversation

xedin
Copy link
Contributor

@xedin xedin commented Apr 2, 2024

Integrate information about versions of prebuilt libraries into the solver
and prioritize these versions when making decisions if they meet all of the
requirements of undecided terms.

This helps solver to avoid fetching and at the same time allows partual
matches on prebuilt libraries with fallback to package provided versions.

xedin added 4 commits April 2, 2024 09:40
…ilt libraries

Integrate information about versions of prebuilt libraries into the solver
and prioritize these versions when making decisions if they meet all of the
requirements of undecided terms.

This helps solver to avoid fetching and at the same time allows partual
matches on prebuilt libraries with fallback to package provided versions.
…kages

This avoid redundant work for packages that not yet cached
or need a fetch.
@xedin
Copy link
Contributor Author

xedin commented Apr 2, 2024

@swift-ci please test

@MaxDesiatov
Copy link
Contributor

@swift-ci test macos

Copy link
Contributor

@MaxDesiatov MaxDesiatov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only an indentation nit

@xedin
Copy link
Contributor Author

xedin commented Apr 3, 2024

@swift-ci please test

@MaxDesiatov MaxDesiatov enabled auto-merge (squash) April 3, 2024 18:36
@MaxDesiatov
Copy link
Contributor

@swift-ci test windows

@xedin
Copy link
Contributor Author

xedin commented Apr 3, 2024

@swift-ci test macos

1 similar comment
@xedin
Copy link
Contributor Author

xedin commented Apr 4, 2024

@swift-ci test macos

@MaxDesiatov MaxDesiatov merged commit f4ab9a4 into swiftlang:main Apr 4, 2024
furby-tm pushed a commit to wabiverse/swift-package-manager that referenced this pull request May 15, 2024
…ilt libraries (swiftlang#7436)

Integrate information about versions of prebuilt libraries into the solver
and prioritize these versions when making decisions if they meet all of
the requirements of undecided terms.

This helps solver to avoid fetching and at the same time allows partial
matches on prebuilt libraries with fallback to package provided versions.
furby-tm pushed a commit to wabiverse/swift-package-manager that referenced this pull request May 15, 2024
…ilt libraries (swiftlang#7436)

Integrate information about versions of prebuilt libraries into the solver
and prioritize these versions when making decisions if they meet all of
the requirements of undecided terms.

This helps solver to avoid fetching and at the same time allows partial
matches on prebuilt libraries with fallback to package provided versions.
xedin added a commit to xedin/swift-package-manager that referenced this pull request Jul 19, 2024
xedin added a commit to xedin/swift-package-manager that referenced this pull request Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants