-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[PubGrub] Avoid resolving package versions twice in presence of prebuilt libraries #7436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
MaxDesiatov
merged 5 commits into
swiftlang:main
from
xedin:prebuilt-lib-resolution-changes
Apr 4, 2024
Merged
[PubGrub] Avoid resolving package versions twice in presence of prebuilt libraries #7436
MaxDesiatov
merged 5 commits into
swiftlang:main
from
xedin:prebuilt-lib-resolution-changes
Apr 4, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ilt libraries Integrate information about versions of prebuilt libraries into the solver and prioritize these versions when making decisions if they meet all of the requirements of undecided terms. This helps solver to avoid fetching and at the same time allows partual matches on prebuilt libraries with fallback to package provided versions.
…kages This avoid redundant work for packages that not yet cached or need a fetch.
@swift-ci please test |
@swift-ci test macos |
MaxDesiatov
reviewed
Apr 3, 2024
MaxDesiatov
approved these changes
Apr 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, only an indentation nit
@swift-ci please test |
@swift-ci test windows |
@swift-ci test macos |
1 similar comment
@swift-ci test macos |
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
…ilt libraries (swiftlang#7436) Integrate information about versions of prebuilt libraries into the solver and prioritize these versions when making decisions if they meet all of the requirements of undecided terms. This helps solver to avoid fetching and at the same time allows partial matches on prebuilt libraries with fallback to package provided versions.
furby-tm
pushed a commit
to wabiverse/swift-package-manager
that referenced
this pull request
May 15, 2024
…ilt libraries (swiftlang#7436) Integrate information about versions of prebuilt libraries into the solver and prioritize these versions when making decisions if they meet all of the requirements of undecided terms. This helps solver to avoid fetching and at the same time allows partial matches on prebuilt libraries with fallback to package provided versions.
xedin
added a commit
to xedin/swift-package-manager
that referenced
this pull request
Jul 19, 2024
…of prebuilt libraries (swiftlang#7436)" This reverts commit f4ab9a4.
xedin
added a commit
to xedin/swift-package-manager
that referenced
this pull request
Jul 19, 2024
…of prebuilt libraries (swiftlang#7436)" This reverts commit f4ab9a4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integrate information about versions of prebuilt libraries into the solver
and prioritize these versions when making decisions if they meet all of the
requirements of undecided terms.
This helps solver to avoid fetching and at the same time allows partual
matches on prebuilt libraries with fallback to package provided versions.