[6.0][PackageModel] Toolchain: Split SwiftTesting flags between swift compiler and linker #7907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
swiftlang#7903) …iler and linker Keeping them together broke Symbol Graph Extract tool because it cannot handle `-Xlinker` flags. - Adjust `deriveMacOSSpecificSwiftTestingFlags` to produce two arrays - one for swift compiler and one for linker flags. `extraFlags.swiftCompilerFlags` no longer includes `-Xlinker` flags. (cherry picked from commit 84ba94a)
xedin
force-pushed
the
dont-include-testing-linker-flags-into-swift-flags-6.0
branch
from
f6e0976 to
01e29be
Compare
|
@swift-ci please test |
|
@swift-ci please test Windows platform |
bnbarham
approved these changes
Aug 22, 2024
xedin
added a commit
to xedin/swift-package-manager
that referenced
this pull request
Aug 23, 2024
… compiler and linker (swiftlang#7907) - Explanation: Fixes a bug where keeping them together broke Symbol Graph Extract tool because it cannot handle `-Xlinker` flags. - Main Branch PR: swiftlang#7903 - Resolves: rdar://134406349 - Risk: Low (This is technically an NFC since it only re-arranging how to the flags are propagated but doesn't change them). - Reviewed By: @MaxDesiatov - Testing: New tests were added to the test suite. (cherry picked from commit 22b41d0)
xedin
added a commit
that referenced
this pull request
Aug 24, 2024
…ft… (#7908) … compiler and linker - Explanation: Fixes a bug where keeping them together broke Symbol Graph Extract tool because it cannot handle `-Xlinker` flags. - Main Branch PR: #7903 - 6.0 Branch PR: #7907 - Resolves: rdar://134406349 - Risk: Low (This is technically an NFC since it only re-arranging how to the flags are propagated but doesn't change them). - Reviewed By: @MaxDesiatov - Testing: New tests were added to the test suite. (cherry picked from commit 22b41d0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
Fixes a bug where keeping them together broke Symbol Graph Extract tool because it cannot handle
-Xlinkerflags.Main Branch PR: [PackageModel] Toolchain: Split SwiftTesting flags between swift comp… #7903
Resolves: rdar://134406349
Risk: Low (This is technically an NFC since it only re-arranging how to the flags are propagated but doesn't change them).
Reviewed By: @MaxDesiatov
Testing: New tests were added to the test suite.