converting tslint.indent to eslint.@typescript-eslint/indent should also convert occurances of tabs to tab

[jonnytest1]

🐛 Bug Report

indent tabs => @typescript-eslint/indent tab

[JoshuaKGoldberg]

Hi @jonnytest1, thanks for filing an issue on tslint-to-eslint-config! There's not much information on your post to go on, so it's hard to understand what should be done. Could you please fill out all of the bug report template?

[kuzivany]

If I'm not mistaken, @jonnytest1 may be referring to the incorrect conversion for "tabs" in the indent rule.
When using tabs in TSLint the ESLint indent rule option is "tab", not "tabs".

The .eslintrc.js generated by running npx tslint-to-eslint-config has the following indent rule:

        // .eslintrc.js
        // ...
        "@typescript-eslint/indent": [
            "error",
            "tabs"
            // ...

Which according to ESLint should be:

        // .eslintrc.js
        // ...
        "@typescript-eslint/indent": [
            "error",
            "tab"
            // ...

-           "tabs"
+           "tab"

This is the error thrown when trying to lint:

ESLint: 7.9.0

Error: .eslintrc.js:
        Configuration for rule "@typescript-eslint/indent" is invalid:
        Value "tabs" should be equal to one of the allowed values.
        Value "tabs" should be integer.
        Value "tabs" should match exactly one schema in oneOf.

    at validateRuleOptions (node_modules/eslint/lib/shared/config-validator.js:144:19)
    at node_modules/eslint/lib/shared/config-validator.js:199:9
    at Array.forEach (<anonymous>)
    at validateRules (node_modules/eslint/lib/shared/config-validator.js:196:30)
    at validateConfigArray (node_modules/eslint/lib/shared/config-validator.js:324:9)
    at CascadingConfigArrayFactory._finalizeConfigArray (node_modules/eslint/lib/cli-engine/cascading-config-array-factory.js:476:13)
    at CascadingConfigArrayFactory.getConfigArrayForFile (node_modules/eslint/lib/cli-engine/cascading-config-array-factory.js:287:21)
    at FileEnumerator._iterateFilesWithFile (node_modules/eslint/lib/cli-engine/file-enumerator.js:356:43)
    at FileEnumerator._iterateFiles (node_modules/eslint/lib/cli-engine/file-enumerator.js:337:25)
    at FileEnumerator.iterateFiles (node_modules/eslint/lib/cli-engine/file-enumerator.js:287:59)

[JoshuaKGoldberg]

Ah, that's a great catch. Thanks, yes!