rxjs-no-unsafe-takeuntil and fix in rxjs-no-async-subscribe #798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KingDarBoja
reviewed
Nov 7, 2020
src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/no-async-subscribe.ts
Show resolved
Hide resolved
KingDarBoja
reviewed
Nov 7, 2020
KingDarBoja
approved these changes
Nov 7, 2020
There was a problem hiding this comment.
Overall the rule converter looks good to me, just waiting for @JoshuaKGoldberg opinion about the gitignore change.
JoshuaKGoldberg
added
the
status: waiting for author
This reverts commit 3639616
JoshuaKGoldberg
added
status: waiting for reviewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
adding rxjs-no-unsafe-takeuntil converter and fix in rxjs-no-async-subscribe converter (missing 'rxjs/' prefix in new rule name)
also added .idea (Webstorm/InteliJ) folder to .gitignore