Skip to content

Consolidate EmbeddingMetadataStorage into VectorDB #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kyle65463
Copy link
Collaborator

@kyle65463 kyle65463 commented Jun 15, 2025

#69

What was done

  • Removed separate EmbeddingMetadataStorage and EmbeddingStore classes and consolidated metadata management directly into vector database implementations
  • Refactored vector database interface to handle both embeddings and their associated metadata
    • Updated VectorDB.add() method to accept EmbeddingMetadataObj parameter
    • Added metadata management methods: get_metadata(), update_metadata(), and get_all_embedding_metadata_objects()
  • Updated all tests, benchmarks, integration tests and codebase to use the new unified vector database interface that manages both embeddings and metadata
  • Removed ChromaVectorDB and FAISSVectorDB implementations, keeping only HNSWLibVectorDB for now

Notes

  • Only HNSWLibVectorDB is included in this PR - I will add other vector database implementations in future PRs to ensure this architectural change works correctly with the existing implementation first.

@kyle65463 kyle65463 changed the title Refactor embedding store Consolidate EmbeddingMetadataStorage into VectorDB Jun 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant