AINFRA-778 - Make StorageTests a Swift package test target

[mokagio]

Description

Now that all the frameworks sources are Swift packages (targets in the same Swift package to be precise) we can move the tests there, too. We didn't do that all in one go to avoid big diffs.

Notice:

• The whole Storage/ folder has been removed, including the dedicated Xcode project
• No changes in the test code

Testing information

See green CI.

Additionally, you can run the focused Hardware Storage tests by selecting the Hardware Storage scheme from Xcode.

Screenshots

---

• I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

[dangermattic]

	2 Warnings
⚠️	Modules/Package.swift was changed without updating its corresponding Package.resolved. Please resolve the Swift packages as appropriate to your project setup (e.g. in Xcode or by running swift package resolve).
⚠️	This PR is larger than 300 lines of changes. Please consider splitting it into smaller PRs for easier and faster reviews.

Generated by 🚫 Danger

[wpmobilebot]

📲 You can test the changes from this Pull Request in WooCommerce iOS Prototype by scanning the QR code below to install the corresponding build.

	App Name	WooCommerce iOS Prototype
	Build Number	30639
	Version	PR #15794
	Bundle ID	com.automattic.alpha.woocommerce
	Commit	552f49b
	Installation URL	66tcukolhp9jg

Automatticians: You can use our internal self-serve MC tool to give yourself access to those builds if needed.

[mokagio]

Beats me why Xcode changes the order almost every time there is an edit.

[iamgabrielma]

Thanks for your work on this @mokagio

It does pass CI but I get a crash when running the Storage suite as standalone, specifically on FileStorageTests.test_file_is_loaded() which crashes due force-unwrapping the URL for shipment-provider.plist that we load from the bundle:

Test Case '-[StorageTests.FileStorageTests test_file_is_loaded]' started.
StorageTests/FileStorageTests.swift:25: Fatal error: Unexpectedly found nil while unwrapping an Optional value

I do see the plist file in Tests/StorageTests/Resources, but perhaps the bundle address to FileStorageTests has changed when moving things around?

Separate question, related to the PR but for another time: The suite takes 120+ seconds to run, despite expected to take longer as we seem to write to disk in these tests and perform DB migrations, which makes me think a bunch of these are not needed anymore?

For example: We hold migration tests starting from model 26 to 27, which is 4years+ old and far from being supported when a user installs the app, as well as all the data models since model 1, which was created ~2018 and no user would interact with it now. Thoughts on clearing/deleting some of these?

[mokagio]

@iamgabrielma

It does pass CI but I get a crash when running the Storage suite as standalone, specifically on FileStorageTests.test_file_is_loaded() which crashes due force-unwrapping the URL for shipment-provider.plist that we load from the bundle:

Interesting. It works fine on my end:

🤔

I assume you used the Storage scheme, right? I doubt that it would make a difference, but on which device?

[mokagio]

Separate question, related to the PR but for another time: The suite takes 120+ seconds to run, despite expected to take longer as we seem to write to disk in these tests and perform DB migrations, which makes me think a bunch of these are not needed anymore?

I noticed the tests being very slow, too. See #15742 (comment) and p1748498088604749/1748498018.125619-slack-C6H8C3G23. But this conversation made me realize I never tracked the need to look into it. Now done with https://linear.app/a8c/issue/AINFRA-824

[iamgabrielma]

For some reason I didn't get notified of you reply, I've approved it as seems to be on my end only and CI passes in any case, sorry for blocking this.

I assume you used the Storage scheme, right? I doubt that it would make a difference, but on which device?

Yeah, Storage scheme and simulator iPad (A16) - iOS 18.3.1 from Xcode 16.4 🤔

I noticed the tests being very slow, too. See #15742 (comment) and p1748498088604749/1748498018.125619-slack-C6H8C3G23. But this conversation made me realize I never tracked the need to look into it. Now done with https://linear.app/a8c/issue/AINFRA-824

Thanks!