Skip to content

Remove deprecated .extend transformation pattern #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 2, 2021

Conversation

renatonouman
Copy link
Contributor

@renatonouman renatonouman commented Mar 30, 2021

This PR makes styled-components .extend pattern optional, since it has been deprecated in v4(styled-components/styled-components#1908).

Moreover, appending .withConfig to other extend methods might break unrelated code, i.e. #33

Related to #47, #33 and #48

From #48

  • make extend identifier configurable like other identifiers;
  • set default value to an empty array;
  • add readme/release notes with breaking change information and instructions to re-enable by providing settings.

@renatonouman renatonouman marked this pull request as ready for review March 31, 2021 00:01
@renatonouman
Copy link
Contributor Author

@Igorbek any instructions on how to add this to readme and release notes?

Copy link
Owner

@Igorbek Igorbek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! Could you please add a line to the 'unreleased' section to the CHANGELOG.md file. I just created it.

@renatonouman
Copy link
Contributor Author

Thank you for reviewing this so quickly. Changes made as requested!

@renatonouman renatonouman requested a review from Igorbek April 1, 2021 23:16
@Igorbek
Copy link
Owner

Igorbek commented Apr 2, 2021

Sorry, @renatonouman another pr got merged, please resolve conflicts and update snapshots.

renatonouman added 2 commits April 2, 2021 17:52
…typescript-plugin-styled-components into rn/remove-component-extend
@renatonouman
Copy link
Contributor Author

Done @Igorbek

@Igorbek Igorbek merged commit 2baea96 into Igorbek:master Apr 2, 2021
@renatonouman renatonouman deleted the rn/remove-component-extend branch April 2, 2021 21:22
@renatonouman
Copy link
Contributor Author

Glad to contribute! Thanks for the review and merge!

@renatonouman
Copy link
Contributor Author

Hey @Igorbek! I just want to check with you when do you plan on releasing the next version?
Thanks!

@Igorbek
Copy link
Owner

Igorbek commented Apr 6, 2021

I started preparing it lately, but got interrupted with other stuff, as usual. I'll try to release it tonight. Sorry for inconvenience.

@Igorbek
Copy link
Owner

Igorbek commented Apr 7, 2021

It's now been released https://github.com/Igorbek/typescript-plugin-styled-components/releases/tag/1.5.0
Thank you for the contribution @renatonouman!

@renatonouman
Copy link
Contributor Author

Thank you for the release @Igorbek.
Using the new version in my project already!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants