-
Notifications
You must be signed in to change notification settings - Fork 32
Remove deprecated .extend
transformation pattern
#370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated .extend
transformation pattern
#370
Conversation
@Igorbek any instructions on how to add this to readme and release notes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution! Could you please add a line to the 'unreleased' section to the CHANGELOG.md
file. I just created it.
…-styled-components into rn/remove-component-extend
Co-authored-by: Igor Oleinikov <igor@oleinikov.ru>
Thank you for reviewing this so quickly. Changes made as requested! |
Sorry, @renatonouman another pr got merged, please resolve conflicts and update snapshots. |
…-styled-components into rn/remove-component-extend
…typescript-plugin-styled-components into rn/remove-component-extend
Done @Igorbek |
Glad to contribute! Thanks for the review and merge! |
Hey @Igorbek! I just want to check with you when do you plan on releasing the next version? |
I started preparing it lately, but got interrupted with other stuff, as usual. I'll try to release it tonight. Sorry for inconvenience. |
It's now been released https://github.com/Igorbek/typescript-plugin-styled-components/releases/tag/1.5.0 |
Thank you for the release @Igorbek. |
This PR makes styled-components
.extend
pattern optional, since it has been deprecated in v4(styled-components/styled-components#1908).Moreover, appending
.withConfig
to other extend methods might break unrelated code, i.e. #33Related to #47, #33 and #48
From #48