Fix InputMap load removing spatial_editor actions in editor #102
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuq
approved these changes
Jun 30, 2024
There was a problem hiding this comment.
@Cafezinhu thanks for your contribution! I have tested here and it works for me. Honestly I only tried the BlockCode nodes in 2D scenes before.
| if Engine.is_editor_hint(): | ||
| var actions := InputMap.get_actions() | ||
| for action in actions: | ||
| if action.begins_with("spatial_editor"): |
There was a problem hiding this comment.
@Cafezinhu are there other actions worth re-adding other than the ones beginning with "spatial_editor"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calling
InputMap.load_from_project_settings()inaddons/block_code/ui/picker/categories/category_factory.gdin the editor causes all spatial_editor actions to be lost, making it impossible to use first person camera controls in the 3D tab.This pull request fixes #100 by re-adding all spatial_editor actions after calling
InputMap.load_from_project_settings()and after adding all the Input actions toblock_list, making sure they don't appear in the input blocks.