chore: Move flask filter logic from ViewModels to Services

[AnEnigmaticBug]

Fixes #1344

Changes: Earlier, ViewModels were building flask filter queries themselves and passing them to Services.

This was not good because this leaked the data retrieval logic into the ViewModels. Only the Services should be concerned with data retrieval and they should abstract out that logic.

This change moves the logic into Services where it belongs.

[iamareebjamal]

Resolve codacy issues

[AnEnigmaticBug]

Codacy is complaining that using !! is unsafe in this line: it.filter { order -> order.event != null }.map { order -> order.event!!.id }.

This is actually a false positive since I'm filtering out the null elements before I map the list.

[iamareebjamal]

There's no false positive about nulls in pure kotlin. If it is non null, then you won't need null asserted call

Your filter isn't understandable at the language level. Use order.event.id?:0

[AnEnigmaticBug]

I've the following concern in using order.event.id?:0:

Suppose that somehow, a null managed to by-pass filter(even though it is impossible)

1. The !! version communicates the message that this is an illegal state which shouldn't have occurred.
2. The ?: version communicates that it's ok to add 0 to the list of event ids if we encounter a null.

IMHO even though the above situation will never arise and from a purely functional point of view, both are identical; semantically, !! is more appropriate than ?: in this case.

[iamareebjamal]

Null asserted calls are code smell. Don't use the Elvis operator but remove the null asserted calls

[AnEnigmaticBug]

I've fixed the issue. Now, my code is using mapNotNull which applies map's transformation and then takes only the non-null results.

[iamareebjamal]

@AnEnigmaticBug Please resolve conflicts

[iamareebjamal]

@AnEnigmaticBug Please resolve conflicts

[iamareebjamal]

@AnEnigmaticBug Please resolve conflicts. It has been a month

[iamareebjamal]

@liveHarshit Please fork and resolve conflicts

[aggarwalpulkit596]

@iamareebjamal can i take up on this ?

[aggarwalpulkit596]

@iamareebjamal i need to fix conflicts only i guess?

[iamareebjamal]

Yes

[aggarwalpulkit596]

@iamareebjamal close this