fix: show ErrorSnackMessage in EventDetailsCoordinatorLayout #1557
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RotBolt
changed the title
|
@ShridharGoel @liveHarshit please review |
ShridharGoel
suggested changes
Apr 6, 2019
app/src/main/java/org/fossasia/openevent/general/event/EventDetailsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/event/topic/SimilarEventsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/social/SocialLinksFragment.kt
Outdated
Show resolved
Hide resolved
|
@liveHarshit @ShridharGoel could please you review and help with codacy issue |
liveHarshit
reviewed
Apr 8, 2019
app/src/main/java/org/fossasia/openevent/general/event/EventDetailsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/event/topic/SimilarEventsFragment.kt
Outdated
Show resolved
Hide resolved
app/src/main/java/org/fossasia/openevent/general/social/SocialLinksFragment.kt
Show resolved
Hide resolved
|
resolve conflicts |
|
@anhanh11001 @angmas1 Peer review please |
liveHarshit
reviewed
Apr 29, 2019
app/src/main/java/org/fossasia/openevent/general/event/topic/SimilarEventsFragment.kt
Outdated
Show resolved
Hide resolved
|
@liveHarshit @iamareebjamal updated |
liveHarshit
approved these changes
Apr 30, 2019
iamareebjamal
approved these changes
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1553
Changes:
Change the targetView of SnackBar to
EventDetailsCoordinatorLayoutto show the snackMessage without ScrollingScreenshots for the change:
