Skip to content

fix: show ErrorSnackMessage in EventDetailsCoordinatorLayout #1557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 30, 2019
Merged

fix: show ErrorSnackMessage in EventDetailsCoordinatorLayout #1557

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion app/src/main/java/org/fossasia/openevent/general/event/EventDetailsFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ import kotlinx.android.synthetic.main.content_fetching_event_error.view.retry
import kotlinx.android.synthetic.main.dialog_feedback.view.feedback
import kotlinx.android.synthetic.main.dialog_feedback.view.feedbackTextInputLayout
import kotlinx.android.synthetic.main.dialog_feedback.view.feedbackrating
import kotlinx.android.synthetic.main.fragment_event.eventCoordinatorLayout
import org.fossasia.openevent.general.CircleTransform
import org.fossasia.openevent.general.R
import org.fossasia.openevent.general.about.AboutEventFragmentArgs
Expand Down Expand Up @@ -510,6 +511,9 @@ class EventDetailsFragment : Fragment() {
val bundle = Bundle()
bundle.putLong(EVENT_ID, safeArgs.eventId)
socialLinksFragemnt.arguments = bundle
socialLinksFragemnt.setErrorSnack {
eventCoordinatorLayout.longSnackbar(it)
}
val transaction = childFragmentManager.beginTransaction()
transaction.add(R.id.frameContainerSocial, socialLinksFragemnt).commit()
}
Expand All @@ -522,6 +526,9 @@ class EventDetailsFragment : Fragment() {
eventTopicId?.let { bundle.putLong(EVENT_TOPIC_ID, it) }
eventLocation?.let { bundle.putString(EVENT_LOCATION, it) }
similarEventsFragment.arguments = bundle
similarEventsFragment.setErrorSnack {
eventCoordinatorLayout.longSnackbar(it)
}
childFragmentManager.beginTransaction()
.replace(R.id.frameContainerSimilarEvents, similarEventsFragment).commit()
}
Expand All @@ -548,7 +555,7 @@ class EventDetailsFragment : Fragment() {
rootView.container.isVisible = !show
rootView.eventErrorCard.isVisible = show
val menuItemSize = menuActionBar?.size() ?: 0
for (i in 0..(menuItemSize - 1)) {
for (i in 0 until menuItemSize) {
menuActionBar?.getItem(i)?.isVisible = !show
}
}
Expand Down
13 changes: 10 additions & 3 deletions app/src/main/java/org/fossasia/openevent/general/event/topic/SimilarEventsFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import kotlinx.android.synthetic.main.fragment_similar_events.progressBar
import kotlinx.android.synthetic.main.fragment_similar_events.similarEventsDivider
import kotlinx.android.synthetic.main.fragment_similar_events.similarEventsRecycler
import kotlinx.android.synthetic.main.fragment_similar_events.view.similarEventsRecycler
import kotlinx.android.synthetic.main.fragment_similar_events.view.similarEventsCoordinatorLayout
import org.fossasia.openevent.general.R
import org.fossasia.openevent.general.di.Scopes
import org.fossasia.openevent.general.event.Event
Expand All @@ -26,7 +25,6 @@ import org.fossasia.openevent.general.common.FavoriteFabClickListener
import org.fossasia.openevent.general.event.EventLayoutType
import org.fossasia.openevent.general.utils.Utils.getAnimSlide
import org.fossasia.openevent.general.utils.extensions.nonNull
import org.jetbrains.anko.design.longSnackbar
import org.koin.android.ext.android.get
import org.koin.androidx.scope.ext.android.bindScope
import org.koin.androidx.scope.ext.android.getOrCreateScope
Expand All @@ -43,6 +41,7 @@ class SimilarEventsFragment : Fragment() {
private var similarIdEvents: MutableList<Event> = mutableListOf()
private var similarLocationEvents: MutableList<Event> = mutableListOf()
private var similarEvents: MutableList<Event> = mutableListOf()
private var showErrorSnack: ((String) -> Unit)? = null

override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
Expand Down Expand Up @@ -79,7 +78,7 @@ class SimilarEventsFragment : Fragment() {
similarEventsViewModel.error
.nonNull()
.observe(viewLifecycleOwner, Observer {
rootView.similarEventsCoordinatorLayout.longSnackbar(it)
showErrorSnack?.invoke(it)
})

similarEventsViewModel.progress
Expand Down Expand Up @@ -134,6 +133,14 @@ class SimilarEventsFragment : Fragment() {
similarEventsRecycler.isVisible = !similarEvents.isEmpty()
}

/*
function to set errorSnackMessage CallBack, to be invoked ,
to be invoked when snack error is generated
*/
fun setErrorSnack(errorSnack: (String) -> Unit) {
showErrorSnack = errorSnack
}

private fun setUpAdapter() {
similarEvents.clear()
var id: Long
Expand Down
15 changes: 11 additions & 4 deletions app/src/main/java/org/fossasia/openevent/general/social/SocialLinksFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,15 +11,13 @@ import androidx.lifecycle.Observer
import androidx.recyclerview.widget.LinearLayoutManager
import kotlinx.android.synthetic.main.fragment_social_links.eventHostDetails
import kotlinx.android.synthetic.main.fragment_social_links.socialLinksRecycler
import kotlinx.android.synthetic.main.fragment_social_links.socialLinksCoordinatorLayout
import kotlinx.android.synthetic.main.fragment_social_links.view.progressBarSocial
import kotlinx.android.synthetic.main.fragment_social_links.view.socialLinksRecycler
import kotlinx.android.synthetic.main.fragment_social_links.view.socialLinkReload
import kotlinx.android.synthetic.main.fragment_social_links.view.socialLinksRecycler
import kotlinx.android.synthetic.main.fragment_social_links.view.socialNoInternet
import org.fossasia.openevent.general.R
import org.fossasia.openevent.general.event.EVENT_ID
import org.fossasia.openevent.general.utils.extensions.nonNull
import org.jetbrains.anko.design.longSnackbar
import org.koin.androidx.viewmodel.ext.android.viewModel
import timber.log.Timber

Expand All @@ -29,6 +27,7 @@ class SocialLinksFragment : Fragment() {
private lateinit var rootView: View
private var id: Long = -1
private lateinit var linearLayoutManager: LinearLayoutManager
private var showErrorSnack: ((String) -> Unit)? = null

override fun onCreate(savedInstanceState: Bundle?) {
super.onCreate(savedInstanceState)
Expand Down Expand Up @@ -77,7 +76,7 @@ class SocialLinksFragment : Fragment() {
socialLinksViewModel.error
.nonNull()
.observe(viewLifecycleOwner, Observer {
socialLinksCoordinatorLayout.longSnackbar(it)
showErrorSnack?.invoke(it)
})

socialLinksViewModel.internetError
Expand All @@ -89,6 +88,14 @@ class SocialLinksFragment : Fragment() {
return rootView
}

/*
function to set errorSnackMessage CallBack, to be invoked ,
to be invoked when snack error is generated
*/
fun setErrorSnack(errorSnack: (String) -> Unit) {
showErrorSnack = errorSnack
}

private fun handleVisibility(socialLinks: List<SocialLink>) {
eventHostDetails.isGone = socialLinks.isEmpty()
socialLinksRecycler.isGone = socialLinks.isEmpty()
Expand Down