Skip to content

Run pre-commit in separate workflow #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mathbunnyru
Copy link
Member

@mathbunnyru mathbunnyru commented Jun 1, 2021

Several reasons for this change:

  • PRs like this shouldn't trigger docker build. [pre-commit.ci] pre-commit autoupdate #1339
  • A bit faster CI (1 minute)
  • Unfortunately, we can't fully rely on pre-commit.ci, because we use Docker-based linter and docker is not available in pre-commit.ci

@mathbunnyru
Copy link
Member Author

Related to #1203

@consideRatio consideRatio merged commit aceb763 into jupyter:master Jun 1, 2021
@mathbunnyru
Copy link
Member Author

mathbunnyru commented Jun 1, 2021

@consideRatio we can't merge to the master if there is something in the master which is not yet built.
This will cause errors.
The reason for that is that in the docker builds we clone the wiki in the beginning, and at the end of the build update the wiki.
And in between, we build the images (it's a long step that takes more than 30 minutes now).
And then there will be two commits in the docs which change the docs in a different way.
So, the second build will not update wiki (manifests).
And so the CI will fail

@consideRatio
Copy link
Member

Wooops ah, did i merge this PR and trigger a workflow running alongside another workflow triggered via some other PR that got merged independently?

@mathbunnyru
Copy link
Member Author

Yes, #1340 was merged 16 minutes before you merged, and that's why there are two simultaneous runs right now.

@mathbunnyru
Copy link
Member Author

And, the first merge is done.
Your merge will probably fail (because of the docs).

@mathbunnyru
Copy link
Member Author

@consideRatio I updated the description of the situation and created a mitigation PR.
The build failed as I described: https://github.com/jupyter/docker-stacks/runs/2717699712

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants