Skip to content

Clone wiki only for steps which need it #1343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2021

Conversation

mathbunnyru
Copy link
Member

@mathbunnyru mathbunnyru commented Jun 1, 2021

This change is to address the situation in #1341 (also happened with me once).

Now we can't merge to the master if there is something in the master which is not yet built.
This will cause errors.
The reason for that is that in the docker builds we clone the wiki in the beginning, and at the end of the build update the wiki.
And in between, we build the images (it's a long step that takes more than 30 minutes now).
And then there will be two commits in the docs which change the docs in a different way.
So, the second build will not update wiki (manifests).
And so the CI will fail.

This commit uses wiki only for a minute:

  • clone wiki (seconds)
  • hook everything (1min15s)
  • push wiki if it's master (seconds)

This way we lock the wiki only for a minute, so we have much more chances with the situation like I described.

@mathbunnyru
Copy link
Member Author

This prevents from the master merge errors, so let give this a try, I think this is a good change.

@mathbunnyru mathbunnyru merged commit 4186d8f into jupyter:master Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant