Skip to content

fix: Feedback - button and crashes #2185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 27, 2019
Merged

fix: Feedback - button and crashes #2185

merged 1 commit into from
Jul 27, 2019

Conversation

liveHarshit
Copy link
Member

@liveHarshit liveHarshit commented Jul 26, 2019 •
edited
Loading

Fixes #2175
Fixes #2184

@auto-label auto-label bot added the fix label Jul 26, 2019
ShridharGoel
ShridharGoel previously approved these changes Jul 26, 2019
View reviewed changes
iamareebjamal
iamareebjamal reviewed Jul 26, 2019
View reviewed changes
@ShridharGoel ShridharGoel dismissed their stale review July 26, 2019 21:22

Changes required

@liveHarshit liveHarshit changed the title fix: Feedback button fix: Feedback - button and crashes Jul 27, 2019
@liveHarshit
Copy link
Member Author

Updated

iamareebjamal
iamareebjamal reviewed Jul 27, 2019
View reviewed changes
app/src/main/res/layout/content_event.xml
android:id="@+id/feedbackBtn"
style="@style/ThreeDS2TextButtonStyle"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For UI.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does it do which is not in default style?

Copy link
Member Author

@liveHarshit liveHarshit Jul 27, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It shows elevation and boundary line. Even if a transparent background is set.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging this. But I see no documentation for this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found it. It is from the stripe library.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. Please revert it in the next development iteration ASAP.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow. Please revert it in the next development iteration ASAP.

Sure 👍

iamareebjamal
iamareebjamal reviewed Jul 27, 2019
View reviewed changes
app/src/main/res/layout/content_event.xml Outdated
@@ -555,14 +555,15 @@
android:visibility="gone"
tools:visibility="visible"/>

<Button
<com.google.android.material.button.MaterialButton
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? It happens automatically when android inflates the layout

iamareebjamal
iamareebjamal reviewed Jul 27, 2019
View reviewed changes
app/src/main/res/values/strings.xml Outdated
@@ -356,11 +356,11 @@
<string name="and_i_m_up_for">And I\'m up for</string>
<string name="what_type">What Sounds good?</string>
<string name="feedback">Feedback</string>
<string name="write_feedback">Write Feedback</string>
<string name="write_feedback">WRITE A FEEDBACK</string>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay. I just follow the play store for UI.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Button text is automatically capitalized

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes right sorry. I have changed it for text view.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not capitalizing with that style. Added an extra attribute.

@liveHarshit liveHarshit mentioned this pull request Jul 27, 2019
Merged
@liveHarshit
Copy link
Member Author

Updated

iamareebjamal
iamareebjamal reviewed Jul 27, 2019
View reviewed changes
app/src/main/res/layout/content_event.xml Outdated
@@ -557,12 +557,14 @@

<Button
android:id="@+id/feedbackBtn"
style="@style/ThreeDS2TextButtonStyle"
android:textAllCaps="true"
android:textAlignment="center"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unneeded

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

@iamareebjamal iamareebjamal merged commit 506a3cf into fossasia:development Jul 27, 2019
@liveHarshit liveHarshit deleted the 2175 branch July 27, 2019 20:04
@liveHarshit liveHarshit mentioned this pull request Jul 30, 2019
Closed
liveHarshit added a commit to liveHarshit/open-event-attendee-android that referenced this pull request Aug 11, 2019
@liveHarshit
fix: Feedback - button and crashes (fossasia#2185)
8739ebf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iamareebjamal iamareebjamal iamareebjamal approved these changes

@anhanh11001 anhanh11001 anhanh11001 left review comments

@ShridharGoel ShridharGoel ShridharGoel left review comments

Assignees
No one assigned
Labels
fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

App crashes on writing feedback after 2nd UI overlapping in event details
4 participants
@liveHarshit @iamareebjamal @ShridharGoel @anhanh11001